[codex] Enforce Effect error handling conventions#3380
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Needs human review This PR modifies Macroscope configuration files ( No code changes detected at You can customize Macroscope's approvability policy. Learn more. |
b7c64f6 to
cce6723
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Opus model downgraded silently
- Restored the model from claude-opus-4-7 back to claude-opus-4-8, matching what main uses, since the downgrade was an incorrect assumption by a Codex agent that the model wasn't supported.
Or push these changes by commenting:
@cursor push 640dafc23e
Preview (640dafc23e)
diff --git a/.macroscope/check-run-agents/effect-service-conventions.md b/.macroscope/check-run-agents/effect-service-conventions.md
--- a/.macroscope/check-run-agents/effect-service-conventions.md
+++ b/.macroscope/check-run-agents/effect-service-conventions.md
@@ -1,6 +1,6 @@
---
title: Effect Service Conventions
-model: claude-opus-4-7
+model: claude-opus-4-8
effort: high
input: full_diff
tools:You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit cce6723. Configure here.
e7012d4 to
205d841
Compare
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
205d841 to
eccaf21
Compare


Summary
Effect.catchTagsfor statically known tagged failures while preserving exhaustive and structural catch exceptionsValidation
pnpm vp checkpnpm vp run typecheckNote
Low Risk
Documentation-only change to a CI check agent; no runtime or production code paths are modified.
Overview
Extends the Effect service conventions Macroscope agent (
.macroscope/check-run-agents/effect-service-conventions.md) with new rules for errors and recovery, without changing application code.Error safety and translation: Error fields and log annotations must stay bounded—no raw payloads, credentials, or serialized causes in
detail/message; real failures stay oncause. At translation boundaries, structured domain errors on the target channel should pass through; only unknown failures get wrapped, optionally via static factories on the target error class.Catch and construction: Known tagged failures should use
Effect.catchTags(notcatchTagor tag-onlycatchIf). Trivial constructor-only error helpers are disallowed; build errors at the failure site unless a mapper does real normalization.Reporting: The check defaults to failure; a clean run must output exactly
All clearon one line with no extra commentary.Reviewed by Cursor Bugbot for commit eccaf21. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Enforce Effect error handling conventions in the codex agent check
Expands effect-service-conventions.md with five new directives covering error attribute safety, translation boundary behavior, tag-based recovery patterns, construction-site discipline, and static factory usage.
detail/serialized cause fields are disallowedEffect.catchTagsis preferred for statically known tagged failures;catchIffor tag-based recovery andcatchTagare discouragedAll clearon a single lineMacroscope summarized eccaf21.